ggml : hide ggml_object, ggml_cgraph, ggml_hash_set #9408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
github-actions
bot
added
Vulkan
ggerganov
force-pushed
the
gg/ggml-hide-structs
branch
from
fec54b5 to
28aa818
Compare
ggerganov
changed the title
ggerganov
changed the title
ggerganov
force-pushed
the
gg/ggml-hide-structs
branch
from
28aa818 to
db647be
Compare
ggml-ci
ggerganov
force-pushed
the
gg/ggml-hide-structs
branch
from
db647be to
ee15445
Compare
ggerganov
changed the title
slaren
approved these changes
Sep 11, 2024
ggml/src/ggml.c
Outdated
Comment on lines
19204
to
19207
| void ggml_graph_add_node(struct ggml_cgraph * cgraph, struct ggml_tensor * tensor) { | ||
| cgraph->nodes[cgraph->n_nodes] = tensor; | ||
| cgraph->n_nodes++; | ||
| } |
There was a problem hiding this comment.
GGML_ASSERT(cgraph->size > cgraph->n_nodes)
ggerganov
added
the
merge ready
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
* ggml : hide ggml_object, ggml_cgraph, ggml_hash_set ggml-ci * ggml : add ggml-impl.h to backends * ggml : fix compiler warnings ggml-ci * ggml : add assert upon adding nodes
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* ggml : hide ggml_object, ggml_cgraph, ggml_hash_set ggml-ci * ggml : add ggml-impl.h to backends * ggml : fix compiler warnings ggml-ci * ggml : add assert upon adding nodes
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* ggml : hide ggml_object, ggml_cgraph, ggml_hash_set ggml-ci * ggml : add ggml-impl.h to backends * ggml : fix compiler warnings ggml-ci * ggml : add assert upon adding nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide some
ggmlstructs from the public APIFurther changes in a similar spirit are in a separate PR: #9431